Fix internet gateway no-cascade delete logic - #11016
Open
ijsnow wants to merge 1 commit into
Open
Conversation
Rework `vpc_delete_internet_gateway_no_cascade` to block on routes and soft-delete the attachments, mirroring the cascade path except that routes are rejected rather than deleted. Previously a no-cascade delete would block if ip attachments existed and didn't check for routes. Fixes oxidecomputer#10976
This was referenced Aug 6, 2026
Contributor
|
We'll also want to update the API doc comment, might just be a case of reverting #10940 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework
vpc_delete_internet_gateway_no_cascadeto block on routes and soft-delete the attachments, mirroring the cascade path except that routes are rejected rather than deleted. Previously a no-cascade delete would block if ip attachments existed and didn't check for routes.Fixes #10976