omdb: add facility for abandoning a saga #7791
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjcolombo
force-pushed
the
gjcolombo/abandon-ship
branch
from
be46c6b to
397d5d7
Compare
gjcolombo
force-pushed
the
gjcolombo/abandon-ship
branch
from
397d5d7 to
f1868f0
Compare
|
I've rebased onto the latest main and retested as noted in the PR description. I feel like I might be under-testing this a bit, so am especially open to suggestions for other things to try here. |
davepacheco
approved these changes
Apr 16, 2025
| it will not resume executing the saga. | ||
|
|
||
| - Other Nexuses will not adopt and resume the saga, even if its current assigned | ||
| Nexus is removed from the system. |
There was a problem hiding this comment.
Suggested change
| Nexus is removed from the system. | |
| Nexus is expunged. |
| If the saga's current Nexus is actively driving it, the saga will continue to | ||
| execute even if it is abandoned. You should only proceed if: | ||
|
|
||
| - you've stopped the saga's assigned Nexus and are prepared to undo any changes |
There was a problem hiding this comment.
Suggested change
| - you've stopped the saga's assigned Nexus and are prepared to undo any changes | |
| - you've stopped the saga's assigned Nexus AND are prepared to undo any changes |
gjcolombo
commented
Apr 16, 2025
| /// If this status indicates that the relevant SEC might be active, returns | ||
| /// `Err`. If the relevant SEC is thought to be inactive, or the saga used | ||
| /// to produce this status had no SEC, returns `Ok`. | ||
| fn as_result(self) -> anyhow::Result<()> { |
There was a problem hiding this comment.
nits: should probably be into_result since this consumes self. Also, the doc comment could be a little clearer about what's returned here: it's Ok if there's sufficient evidence to be confident that this saga doesn't belong to an active SEC and Err otherwise.
Define an "abandoned" saga state. An abandoned saga will not begin to be executed by any SEC. Technicians mark sagas as abandoned using omdb; this requires the saga's current executor not to be running (otherwise it could receive a state update from Steno that will clobber the Abandoned state). This commit defines the new state in the database schema and fixes up the DB crates accordingly, but adds no affordances for applying the new saga state or considering it when deciding what sagas to recover.
gjcolombo
force-pushed
the
gjcolombo/abandon-ship
branch
from
f1868f0 to
59026d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
Abandonedsaga state. This state disqualifies a saga from being picked up by Nexus saga recovery. (A running saga will continue running if it is Abandoned, and continued saga execution may end up clobbering the Abandoned state entirely.) Add anomdbsubcommand to move a saga to this state (and refactor a bit to avoid duplicating code with theinject-errorsubcommand).Tested (so far) by:
svcadm restart), but is no longer recovered once abandoned (and can't be completed anymore); if I manually move the saga back to Running and restart its SEC again, the saga is picked up normally.Fixes #7730.