Allow external API clients to request a gzipped response#9995
Draft
david-crespo wants to merge 5 commits intomainfrom
Draft
Allow external API clients to request a gzipped response#9995david-crespo wants to merge 5 commits intomainfrom
david-crespo wants to merge 5 commits intomainfrom
Conversation
The crucible rev bump brings in progenitor-client 0.13, so ProgenitorOperationRetry and the crucible/pantry client construction need to use the current progenitor_client and reqwest instead of the v0.10/v0.12 compat shims. Remove the now-unused progenitor-client010 workspace dep, reqwest012 nexus dep, and the duplicate From impl for progenitor_client010::Error.
david-crespo
force-pushed
the
dropshot-gzip-support
branch
from
4e5301c to
9e28d9e
Compare
Contributor
Author
|
The test failure is oxidecomputer/dropshot#1554 adding explicit HTTP statuses to websocket endpoints in the OpenAPI schemas, which means I need to do an API version bump in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing oxidecomputer/dropshot#1448, which adds gzip compression. It is merged but not in a release yet. In the project list test the response is 598 bytes compressed vs 1920 bytes uncompressed. This matches my other experiments showing an ~80% reduction in size.
Relies on: