Conversation
ahl
approved these changes
May 9, 2025
smklein
added a commit
to oxidecomputer/omicron
that referenced
this pull request
May 12, 2025
The support bundle viewer logic has been moved to an external crate: https://github.com/oxidecomputer/support-bundle-viewer This PR is mostly "move-only": - Use that crate - Keep the "internal Nexus API" bits within omdb This enables external usage of the support bundle inspector, e.g., in: oxidecomputer/oxide.rs#1093
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mimics commands already present in omdb, relying on the new https://github.com/oxidecomputer/support-bundle-viewer crate to access the same logic for the TUI.
The implementation of
SupportBundleAccessoris similar to the implementation used by the internal API, but in this case, using the external API instead.