Simplify transformation of TQ cert chain for use by rustls.#83
Merged
Conversation
This approach puts simpliciy above efficiency: the SliceReader makes this very simple but it holds a reference to the TQ cert chain so we must copy each cert instead of draining the bytes from the original `Vec<u8>`.
labbott
approved these changes
Jul 24, 2025
labbott
left a comment
labbott
left a comment
Contributor
There was a problem hiding this comment.
This is much easier to follow
Collaborator
Author
|
tested successfully on |
andrewjstone
approved these changes
Jul 28, 2025
andrewjstone
left a comment
andrewjstone
left a comment
Collaborator
There was a problem hiding this comment.
Definitely easier to follow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This approach puts simpliciy above efficiency: the SliceReader makes this very simple but it holds a reference to the TQ cert chain so we must copy each cert instead of draining the bytes from the original
Vec<u8>.