resource(vpc_firewall_rules): support new api changes#474
Merged
Conversation
sudomateo
commented
Jul 21, 2025
sudomateo
force-pushed
the
sudomateo/wwnpykqrwmws
branch
from
July 24, 2025 02:44
d03b790 to
c6c7ca5
Compare
Collaborator
Author
|
sudomateo
marked this pull request as ready for review
July 24, 2025 02:45
karencfv
approved these changes
Jul 24, 2025
karencfv
left a comment
karencfv
left a comment
Collaborator
There was a problem hiding this comment.
This is excellent, thanks a bunch! Just a couple of minor things, but I'll leave it approved so you don't have to wait some hours for me to take a look again.
Pulled in the Go SDK changes from oxidecomputer/oxide.go#304 which contained changes to the VPC firewall rules APIs. Updated the `oxide_vpc_firewall_rules` resource to account for these changes.
sudomateo
force-pushed
the
sudomateo/wwnpykqrwmws
branch
from
July 24, 2025 18:54
c6c7ca5 to
1b30f94
Compare
lgfa29
added a commit
that referenced
this pull request
Aug 27, 2025
Implement the `ResourceWithStateUpgrade` interface on `vpcFirewallRulesResource` to support upgrading existing Terraform states to the new schema implemented in #474. One important note is that this does not allow users to use new versions of the provider with previous versions of the Oxide API. It only updates existing Terraform states to avoid errors when users upgrade their clusters to a version that contains API changes.
lgfa29
added a commit
that referenced
this pull request
Aug 27, 2025
Implement the `ResourceWithStateUpgrade` interface on `vpcFirewallRulesResource` to support upgrading existing Terraform states to the new schema implemented in #474. One important note is that this does not allow users to use new versions of the provider with previous versions of the Oxide API. It only updates existing Terraform states to avoid errors when users upgrade their clusters to a version that contains API changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled in the Go SDK changes from
oxidecomputer/oxide.go#304 which contained changes to the VPC firewall rules APIs.
Updated the
oxide_vpc_firewall_rulesresource to account for these changes.