misc: update golangci-lint rules

.golangci.yml

@@ -1,9 +1,12 @@
+---
 version: "2"
 
 linters:
   default: standard
   enable:
     - godoclint
+    - unparam
+    - goheader
   disable:
     - errcheck
   settings:
@@ -14,19 +17,25 @@ linters:
       options:
         max-len:
           length: 100
+    goheader:
+      template: |-
+        This Source Code Form is subject to the terms of the Mozilla Public
+        License, v. 2.0. If a copy of the MPL was not distributed with this
+        file, You can obtain one at https://mozilla.org/MPL/2.0/.
 
 formatters:
   enable:
-    - gofmt
-    - golines
     - goimports
+    - golines
   settings:
     golines:
       max-len: 100
       shorten-comments: true
     goimports:
       local-prefixes:
         - github.com/oxidecomputer/terraform-provider-oxide
+  exclusions:
+    generated: disable
 
 run:
   timeout: 5m

Makefile

@@ -90,6 +90,7 @@ fmt: golangci-fmt terrafmt-fmt docs
 golangci-fmt:
 	@ echo "-> Formatting Go code"
 	@ $(GO_TOOL) golangci-lint fmt
+	@ $(GO_TOOL) golangci-lint run --enable-only=goheader --fix
 
 .PHONY: terrafmt
 terrafmt:

internal/provider/address_lot/resource_test.go

@@ -1,3 +1,7 @@
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this
+// file, You can obtain one at https://mozilla.org/MPL/2.0/.
+
 package addresslot_test
 
 import (

internal/provider/credentials/function.go

@@ -1,3 +1,7 @@
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this
+// file, You can obtain one at https://mozilla.org/MPL/2.0/.
+
 package credentials
 
 import (

internal/provider/credentials/function_test.go

@@ -1,3 +1,7 @@
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this
+// file, You can obtain one at https://mozilla.org/MPL/2.0/.
+
 package credentials_test
 
 import (

internal/provider/instance/resource_v1.go

@@ -1,3 +1,7 @@
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this
+// file, You can obtain one at https://mozilla.org/MPL/2.0/.
+
 package instance
 
 import (

internal/provider/provider_test.go

@@ -1,3 +1,7 @@
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this
+// file, You can obtain one at https://mozilla.org/MPL/2.0/.
+
 package provider_test
 
 import (

internal/provider/shared/planmodifiers.go

@@ -1,3 +1,7 @@
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this
+// file, You can obtain one at https://mozilla.org/MPL/2.0/.
+
 package shared
 
 import (

internal/provider/vpc_firewall_rules/resource_test.go

@@ -445,7 +445,7 @@ func TestAccCloudResourceFirewallRules_full(t *testing.T) {
 			},
 			{
 				Config: configUpdate2,
-				Check:  checkResourceUpdate2(resourceName, vpcName),
+				Check:  checkResourceUpdate2(resourceName),
 			},
 			{
 				Config: configUpdate3,
@@ -650,7 +650,7 @@ func checkResourceUpdate(resourceName string) resource.TestCheckFunc {
 	}...)
 }
 
-func checkResourceUpdate2(resourceName, vpcName string) resource.TestCheckFunc {
+func checkResourceUpdate2(resourceName string) resource.TestCheckFunc {
 	return resource.ComposeAggregateTestCheckFunc([]resource.TestCheckFunc{
 		resource.TestCheckResourceAttrSet(resourceName, "id"),
 		resource.TestCheckResourceAttrSet(resourceName, "vpc_id"),