This repository was archived by the owner on May 12, 2020. It is now read-only.
[WIP] Feature/rerendering events based on children #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to solving #14 , but it's just a implementation suggestion. Open for feedback on this one.
The solution i came up with is this:
Every time children of
<ImagesLoaded />
updates, theimagesLoaded instance
re-initializes and fires all events again. This has been solved usingcomponentDidUpdate
forprops.children
-checks.When
componentDidUpdate
fires, I've also added anonUpdate
-prop that can be implemented like this: