Less aggressive quoting#35
Open
mightybyte wants to merge 2 commits into
Open
Conversation
mightybyte
commented
Feb 25, 2018
| , mmorph | ||
| , primitive | ||
| , resourcet >= 1.1.2.1 | ||
| , resourcet >= 1.1.2.1 && < 1.2 |
Collaborator
Author
There was a problem hiding this comment.
I also noticed that csv-conduit does not build with resourcet-1.2, so I added this upper bound.
Collaborator
|
I don't know if I can justify changing the behavior for all users here. I think I'd prefer adding a flag to |
Collaborator
Author
|
Ahh yes, good idea. I'll try to get to it when I have some free time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently csv-conduit outputs the string
""for empty fields. Postgres throws the following error when it encounters this for fields of typedouble precision:So while the current behavior is correct according to the spec, it seems to be less broadly supported in practice. Also, if you're using csv-conduit to transform large files, the current behavior means that every single field will be quoted. This means that you're outputting two additional bytes per field, making the resulting files noticeably larger than they need to be.
This PR only quotes fields if they contain the quote character, which is correct behavior according to the spec.