#331: Relaxed visibility of *Value methods in DefaultCasting, made the DefaultCastingError constructor public #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
made the DefaultCastingError constructor public
|
Hi @Dzeri96 , Thank you for looking into this. Could you review the case raised by the codacy https://app.codacy.com/gh/ozlerhakan/poiji/pull-requests/333/issues#issue-9cdd5c0ed282fdfed95a3e519afde1e5? |
|
Sorry I was sick for like two weeks and didn't get to this. Do I still need to change the test name or did you do it? |
|
No worries! I hope you feel any better. I just created a new branch for the upcoming release ans merged this into it. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #331.
I also took the liberty to change the README in order to better demonstrate a common use-case.
Please change the target branch as you see fit