Skip to content

fix: fall back to exception class name when string is empty (#146)#363

Open
umran666 wants to merge 1 commit into
p-e-w:masterfrom
umran666:fix/empty-exception-messages
Open

fix: fall back to exception class name when string is empty (#146)#363
umran666 wants to merge 1 commit into
p-e-w:masterfrom
umran666:fix/empty-exception-messages

Conversation

@umran666
Copy link
Copy Markdown
Contributor

@umran666 umran666 commented Jun 7, 2026

Falls back to printing the exception's class name in main.py and model.py if the exception's string representation is empty, preventing empty parentheses like Failed () from being printed for exceptions without messages.

Closes #146.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves error reporting in src/heretic/main.py and src/heretic/model.py by stripping whitespace from caught exception messages and falling back to the exception's class name if the string representation is empty. No review comments were provided, so there is no feedback to address.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Printing exceptions outputs empty message if the exception has no message attached, complicating debugging

1 participant