updation of schema and DTOs for football Events , Format and MatchState #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts & matchState of fotball
…ts & matchState of fotball
majorbruteforce
requested changes
Jan 25, 2025
|
|
||
| // Event-specific detail interfaces | ||
| interface GoalDetails { | ||
| team: string; |
There was a problem hiding this comment.
Change type to ObjectId
|
|
||
| interface SubstitutionDetails { | ||
| team: string; | ||
| outPlayer: Player; |
There was a problem hiding this comment.
Instead of storing Player store the teamPlayer reference
| interface InjuryDetails { | ||
| team: string; | ||
| player: Player; | ||
| severity: 'minor' | 'moderate' | 'severe'; |
| interface FoulDetails { | ||
| team: string; | ||
| player: Player; | ||
| type: string; |
| player: Player; | ||
| decision: string; | ||
| minute: number; | ||
| } |
There was a problem hiding this comment.
Change to generic event, desc, minute, data { }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
However i need the review for further changes in the codes :)