Skip to content

feat: add dark mode to landing page#21

Merged
iamanishx merged 2 commits intop-society:mainfrom
burgerphilic18:dark-mode
Jul 7, 2025
Merged

feat: add dark mode to landing page#21
iamanishx merged 2 commits intop-society:mainfrom
burgerphilic18:dark-mode

Conversation

@burgerphilic18
Copy link
Contributor

  • add dark mode colors to index.css
  • fix footer not responding to theme changes

Signed-off-by: Spandan Hota <spandanhota2005@outlook.com>
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @burgerphilic18, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on implementing a dark mode theme for the landing page. It achieves this by defining new, distinct sets of CSS variables for both light and dark themes and updating the footer component to dynamically respond to these theme changes, ensuring a consistent and visually appealing user experience across different modes.

Highlights

  • Dark Mode Implementation: Introduced a comprehensive set of CSS variables for a new dark mode theme within index.css, alongside refined variables for the existing light mode, enabling dynamic theme switching for the landing page.
  • Footer Theme Responsiveness: Modified the Footer component (footer.tsx) to utilize the new theme-aware CSS variables, ensuring its text, social icons, links, and borders correctly adapt to the active light or dark theme.
  • Smooth UI Transitions: Implemented CSS transitions on the main footer element and social media icons to provide a smooth visual experience when the theme changes, enhancing user interaction.
  • Code Refactoring in Footer: Streamlined the 'Quick Links' and 'Policies' sections within the Footer component by converting static list items into dynamically rendered lists using array mapping, improving code readability and maintainability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully introduces a dark mode for the landing page by restructuring CSS variables for theming and updating components to use these new variables. The footer component has also been refactored to dynamically generate links, which improves maintainability.

My review has identified a few issues:

  • A functional change in the footer's anchor links that might break in-page navigation.
  • The new dark theme is missing definitions for a couple of crucial CSS variables (--muted-foreground and --ring), which will lead to UI inconsistencies.
  • A minor code cleanup opportunity to remove an unused CSS variable.

Overall, the changes are good, but the identified issues, particularly the high-severity ones, should be addressed to ensure correctness and a consistent user experience in both themes.

@burgerphilic18
Copy link
Contributor Author

Screenshot From 2025-07-07 14-30-36
Screenshot From 2025-07-07 14-30-52
Screenshot From 2025-07-07 14-31-02

@ujsquared
Copy link
Contributor

image

looks nice, lemme review quickly.

Copy link
Contributor

@ujsquared ujsquared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes requested here and there. Looks pretty merge'able after that.

Signed-off-by: Spandan Hota <spandanhota2005@outlook.com>
@burgerphilic18 burgerphilic18 requested a review from ujsquared July 7, 2025 10:14
Copy link
Contributor

@ujsquared ujsquared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@neoandmatrix neoandmatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice work.

@iamanishx
Copy link
Contributor

@burgerphilic18 looks nice

@iamanishx
Copy link
Contributor

iamanishx commented Jul 7, 2025

image
this part in the light theme needs to be improved !!! may be black text color instead of yellow

image
is this okayyy ? or we should change the color here ?

@ujsquared @neoandmatrix

@neoandmatrix
Copy link
Member

Mostly the system will be used , not 1st priority issue according to me works so can be tweaked later also or can be addressed now also.

@iamanishx
Copy link
Contributor

Mostly the system will be used , not 1st priority issue according to me works so can be tweaked later also or can be addressed now also.

addressing this rn is better nobody will listen afterwards

@iamanishx
Copy link
Contributor

image
this part in the light theme needs to be improved !!! may be black text color instead of yellow

@burgerphilic18 please change the text color from yellow to black here

@ujsquared
Copy link
Contributor

addressing this rn is better nobody will listen afterwards

i was thinking to use this as an inviting simple issue for people who haven't contributed yet. what say?

@neoandmatrix
Copy link
Member

i was thinking to use this as an inviting simple issue for people who haven't contributed yet. what say?

Let's complete this imho, there will be many small issue that can be tackled by beginners in comming development also.

@ujsquared
Copy link
Contributor

ujsquared commented Jul 7, 2025

Let's complete this imho, there will be many small issue that can be tackled by beginners in comming development also.

haina? let's merge this. @iamanishx

@iamanishx
Copy link
Contributor

addressing this rn is better nobody will listen afterwards

i was thinking to use this as an inviting simple issue for people who haven't contributed yet. what say?

yess it would be better

@iamanishx iamanishx merged commit 7e191b3 into p-society:main Jul 7, 2025
2 checks passed
@iamanishx
Copy link
Contributor

@neoandmatrix @ujsquared merged lessgoo

@burgerphilic18 burgerphilic18 deleted the dark-mode branch December 5, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants