[codex] Prepare Aleph v1.0.3 MLX CUDA runtime framing#21
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAleph v1.0.3 is a patch release that updates monorepo versions and clarifies local MLX platform support (Apple Silicon as maintainer path; Linux CUDA as upstream expansion), with runtime preflight adjustments, web explorer UI/localization changes, scoring exact-match short-circuits, related tests, and a metrics plan. Changesv1.0.3 Release Patch
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/app/components/aleph-explorer.tsx`:
- Around line 910-912: The Chinese out-of-band note string (rightOobNote) still
contains the English phrase "y itself"; update this to a Chinese equivalent that
matches the localization style and aligns with the existing sliderTargetSuffix
usage (e.g., replace "y itself" with the same Chinese wording used by
sliderTargetSuffix), ensuring rightOobTitle/rightOobNote remain consistent in
meaning and formatting within the aleph-explorer.tsx component.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: e07369f3-3473-45e0-8fec-93ea1fe8f685
📒 Files selected for processing (1)
web/app/components/aleph-explorer.tsx
📜 Review details
🔇 Additional comments (1)
web/app/components/aleph-explorer.tsx (1)
35-35: LGTM!Also applies to: 751-755, 771-772, 777-777, 783-784, 787-787, 811-816, 868-878, 894-900, 906-907, 915-915, 1772-1772, 2282-2282, 2342-2345, 2925-2925
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/api/aleph_api/services/scoring.py`:
- Around line 23-27: The current logic treats two empty normalized strings as
identical because difflib.SequenceMatcher("", "") returns 1.0; update the
function that computes similarity (the block using variables target and actual
and difflib.SequenceMatcher) to explicitly handle empty normalized inputs by
returning 0.0 when both target.strip() and output.strip() are empty, otherwise
proceed with the existing equality check (target == actual) and then fall back
to difflib.SequenceMatcher(a=target, b=actual).ratio().
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: b272f72e-f9cf-4be9-87c9-3522ff2bb020
📒 Files selected for processing (4)
apps/api/aleph_api/services/scoring.pyapps/api/tests/test_scoring.pydocs/plans/metric-and-backend-workflow.mdweb/app/components/aleph-explorer.tsx
📜 Review details
🔇 Additional comments (12)
web/app/components/aleph-explorer.tsx (10)
35-35: LGTM!
347-363: LGTM!
635-635: LGTM!Also applies to: 1661-1661, 1885-1885
748-752: LGTM!Also applies to: 768-768, 774-774
808-808: LGTM!Also applies to: 811-813, 865-865, 871-875, 891-891, 897-897, 903-904, 907-909, 912-912
1770-1770: LGTM!
2280-2280: LGTM!
2340-2343: LGTM!
2923-2923: LGTM!
2962-2963: LGTM!apps/api/tests/test_scoring.py (1)
89-92: LGTM!docs/plans/metric-and-backend-workflow.md (1)
1-73: LGTM!
What changed
This branch prepares Aleph v1.0.3 as a small release/docs/UI framing update after upstream MLX added Linux CUDA backend support.
1.0.3, including lockfiles and/healthdocs/releases/1.0.3.mdand a changelog entrysearch/preflight.pyso Linux no longer fails solely for not beingarm64; it now prints a Linux CUDA hardware note insteadWhy
Upstream MLX added Linux CUDA backend support, but several Aleph docs and bits of UI copy still described the local white-box route as if MLX itself were Apple-Silicon-only. This patch makes the repository's runtime framing more accurate without changing Aleph's product claims, run contract, or evidence boundaries.
Impact
AlephRuncontract changesValidation
npm run lintnpm run testnpm --workspace web run buildgit diff --check