Open
Conversation
cortze
approved these changes
Jun 30, 2022
| // end signals the event loop to exit gracefully | ||
| func (ui *TerminalManager) end() { | ||
| ui.doneCh <- struct{}{} | ||
| return ui.app.Run() |
Collaborator
There was a problem hiding this comment.
definitely a better way of managing the "bocking" app.Run() call
| } | ||
| w.tm = NewTerminalManager(w.CurrentGame) | ||
|
|
||
| return w.tm.Run(ctx, &w.uiInitialized) |
Collaborator
There was a problem hiding this comment.
same here, I have to get used to returning the result of the underlying call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a bunch of code cleanups over #26 that I was too lazy to split into multiple commits.
Not yet been manually tested and might need some additional polishing.