method for getting webseed url, bugfix v1 single-file torrent creation#8
Merged
sneakers-the-rat merged 3 commits intomainfrom Aug 5, 2025
Merged
method for getting webseed url, bugfix v1 single-file torrent creation#8sneakers-the-rat merged 3 commits intomainfrom
sneakers-the-rat merged 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By the time we have piece ranges, we don't know about the torrent
info.namefield anymore, so we can't construct URLs accurately.Give that responsibility to the relevant piece range classes, giving them a
webseed_urlmethod that can be used to get the full url to request from some url that's used as a webseed.so e.g. for a multi-file torrent named
my_torrentwith a filea.exe, a webseed given ashttps://example.com/data/should have the file stored athttps://example.com/data/my_torrent/a.exethis also fixes v1-only single file torrents (a rare and discouraged case) which improperly added the metadata to the
fileslist, rather than just havingnameandlength.📚 Documentation preview 📚: https://torrent-models--8.org.readthedocs.build/en/8/