Skip to content

chore: add extraEnv to performance sidecars#63

Merged
kjubybot-p2p merged 1 commit into
mainfrom
chore/extra-env
Apr 27, 2026
Merged

chore: add extraEnv to performance sidecars#63
kjubybot-p2p merged 1 commit into
mainfrom
chore/extra-env

Conversation

@kjubybot-p2p
Copy link
Copy Markdown
Contributor

@kjubybot-p2p kjubybot-p2p commented Apr 27, 2026

Summary by CodeRabbit

  • New Features
    • Added optional custom environment variables for performance monitoring deployments, enabling users to configure additional environment settings for performance-related services as needed.

@kjubybot-p2p kjubybot-p2p self-assigned this Apr 27, 2026
@kjubybot-p2p kjubybot-p2p requested review from a team, julio-p2p and selfuryon and removed request for a team April 27, 2026 16:48
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8dd55b4d-fba9-4b3c-ab28-dfc66fd4134b

📥 Commits

Reviewing files that changed from the base of the PR and between add708d and c1ce66d.

📒 Files selected for processing (1)
  • oracle/templates/deployment-performance.tpl

Walkthrough

This pull request modifies a Helm deployment template to add optional custom environment variables for the performance-collector and performance-web containers by conditionally rendering a new env: section from .Values.extraEnv configuration.

Changes

Cohort / File(s) Summary
Helm Template Enhancement
oracle/templates/deployment-performance.tpl
Adds conditional env: section supporting optional custom environment variables via .Values.extraEnv for both performance containers; existing envFrom behavior preserved.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 With whiskers twitched and paws at rest,
I've added vars to pass the test!
Environment knobs, both great and small,
Now customizable for one and all! 🌱

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: add extraEnv to performance sidecars' accurately describes the main change: adding extraEnv support to performance sidecar containers.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/extra-env

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kjubybot-p2p kjubybot-p2p merged commit c590597 into main Apr 27, 2026
8 checks passed
@kjubybot-p2p kjubybot-p2p deleted the chore/extra-env branch April 27, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants