Skip to content

fix: force target=_blank links to open in new tabs #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akhileshthite merged 1 commit into from
Jan 31, 2026
Merged

fix: force target=_blank links to open in new tabs #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 33 additions & 32 deletions src/context-menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,31 +270,31 @@ export function attachContextMenus(browserWindow, windowManager) {
label: "Open Link in New Tab",
click: () => {
// First, attempt to add the URL as a new tab in the current window
const escapedUrl = params.linkURL.replace(/'/g, "\\'");

browserWindow.webContents
.executeJavaScript(`
const tabBar = document.querySelector('#tabbar');
if (tabBar && typeof tabBar.addTab === 'function') {
tabBar.addTab('${escapedUrl}');
// Indicate success so main process knows no fallback is required
true;
} else {
// Tab bar not available – signal fallback
false;
}
(function() {
const tabBar = document.querySelector('tab-bar');
const url = ${JSON.stringify(params.linkURL)};
if (tabBar && typeof tabBar.addTab === 'function') {
tabBar.addTab(url);
return true;
}
const oldTabBar = document.querySelector('#tabbar');
if (oldTabBar && typeof oldTabBar.addTab === 'function') {
oldTabBar.addTab(url);
return true;
}
return false;
})()
`)
.then((added) => {
if (!added && windowManagerInstance) {
// Fallback: open in new window if tab creation failed
windowManagerInstance.open({ url: params.linkURL });
if (!added) {
console.warn('Failed to find tab bar for new tab');
}
})
.catch((err) => {
console.error('Failed to add tab from context menu:', err);
if (windowManagerInstance) {
windowManagerInstance.open({ url: params.linkURL });
}
});
},
})
Expand Down Expand Up @@ -329,31 +329,32 @@ export function attachContextMenus(browserWindow, windowManager) {
// Intercept window.open / target="_blank" requests and try to add them as tabs
webviewWebContents.setWindowOpenHandler(({ url }) => {
// First, attempt to add the URL as a new tab in the current window (renderer side)
const escapedUrl = url.replace(/'/g, "\\'");

browserWindow.webContents
.executeJavaScript(`
const tabBar = document.querySelector('#tabbar');
if (tabBar && typeof tabBar.addTab === 'function') {
tabBar.addTab('${escapedUrl}');
// Indicate success so main process knows no fallback is required
true;
} else {
// Tab bar not available – signal fallback
false;
}
(function() {
const tabBar = document.querySelector('tab-bar');
const url = ${JSON.stringify(url)};
if (tabBar && typeof tabBar.addTab === 'function') {
tabBar.addTab(url);
return true;
}
// Fallback for older selector if web component not found
const oldTabBar = document.querySelector('#tabbar');
if (oldTabBar && typeof oldTabBar.addTab === 'function') {
oldTabBar.addTab(url);
return true;
}
return false;
})()
`)
.then((added) => {
if (!added && windowManagerInstance) {
// Fallback: open in new window if tab creation failed
windowManagerInstance.open({ url });
if (!added) {
console.warn('Failed to find tab bar to add tab for url:', url);
}
})
.catch((err) => {
console.error('Failed to add tab from windowOpenHandler:', err);
if (windowManagerInstance) {
windowManagerInstance.open({ url });
}
});

// Always deny the automatic window creation – we will handle it ourselves
Expand Down