bm_sim: fix spurious duplicate ageing notifications for entries that remain aged across sweeps - #1443
Open
Devansh-567 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Devansh-567 <devansh.jay.singh@gmail.com>
Devansh-567
force-pushed
the
fix-spurious-ageing-notifications
branch
from
August 21, 2026 04:56
8c5acf3 to
f604d32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR fixes an issue where AgeingMonitor::do_sweep() sends duplicate ageing notifications to the controller on subsequent sweeps for entries that are still aged and untreated.
Problem
prev_sweep_entries keeps track of entry handles reported in the previous sweep so we don't re-notify the controller. However, prev_sweep_entries was getting cleared every sweep and only populated inside if (!entries.empty()). If a sweep didn't discover any new aged entries, entries was empty so prev_sweep_entries was left empty too. On the next sweep, any existing aged entry was treated as new again, causing duplicate notifications every other sweep. Also, AgeingTest.NoDuplicate wasn't catching this because the blocking read() call accidentally allowed timing gaps that masked the duplicate messages.
Fix
Testing