fix off-by-one error in LAG index validation (re-opening #1440) - #1444
Open
Devansh-567 wants to merge 1 commit into
Open
fix off-by-one error in LAG index validation (re-opening #1440)#1444Devansh-567 wants to merge 1 commit into
Devansh-567 wants to merge 1 commit into
Conversation
Signed-off-by: Devansh-567 <devansh.jay.singh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fixes an off-by-one error in McSimplePreLAG::mc_set_lag_membership where lag_index validation used > instead of >=.
This replaces and re-opens the changes from closed PR #1440 onto a clean branch.
Context & Solution
In C++, 0-based indexing for fixed-size structures means that for LAG_MAX_ENTRIES, valid indices are 0 through LAG_MAX_ENTRIES - 1. Passing lag_index == LAG_MAX_ENTRIES bypassed the previous lag_index > LAG_MAX_ENTRIES boundary check, leading to potential out-of-bounds access.
Updating the check to lag_index >= LAG_MAX_ENTRIES correctly catches this edge case and returns ERROR.
Changes Made