build: fix ctags target name and filter missing directories#5559
Merged
fruffy merged 4 commits intop4lang:mainfrom Mar 28, 2026
Merged
build: fix ctags target name and filter missing directories#5559fruffy merged 4 commits intop4lang:mainfrom
fruffy merged 4 commits intop4lang:mainfrom
Conversation
Fixes p4lang#5530. - Rename the target from 'tags' to 'ctags' to match user expectations and dependencies in other CMakeLists.txt files. - Filter the CTAGS_DIRS list to only include directories that actually exist, removing the missing 'extensions' directory warning. Signed-off-by: Vineet1101 <vineetgoel692@gmail.com>
fruffy
added
the
infrastructure
fruffy
approved these changes
Mar 28, 2026
jafingerhut
approved these changes
Mar 28, 2026
Contributor
jafingerhut
left a comment
jafingerhut
left a comment
There was a problem hiding this comment.
I have tried out these changes on a local VM, and I can build both ctags and etags targets with neither errors nor warnings. LGTM
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5530.
All targets now execute cleanly.
Tested on Ubuntu with
exuberant-ctagsinstalled here are the logs from the terminal:$ cmake --build build --target ctags && cmake --build build --target etags [100%] Generating ctags [100%] Built target ctags [100%] Generating extended ctags [100%] Built target etags