Conversation
Signed-off-by: nishant11-tchy <nishantnnnn11@gmail.com>
Signed-off-by: nishant11-tchy <nishantnnnn11@gmail.com>
|
Hi, I’ve worked on improving the CMake behavior to avoid unnecessary regeneration of test files. The update ensures that test files are only generated when required, instead of on every CMake run. This helps reduce configuration time without affecting existing functionality. I’ve verified the changes locally by running CMake multiple times and confirming that files are not regenerated unnecessarily. Please let me know if any changes or improvements are needed. Thanks! |
|
There are 0 changed files. |
Signed-off-by: nishant11-tchy <nishantnnnn11@gmail.com> Made-with: Cursor
|
@nishant11-tchy I am not sure what is going on here, but given that you have two PRs with 0 changes, perhaps you are making changes to the main / master branch in your fork, creating a PR, then continuing to push additional changes to that same main/master branch in your fork? If you do that, it will affect all PRs using that branch. That is why most github workflows for creating PRs say that you should create a unique branch name for each PR that you want to create. I'd suggest searching for github documentation on creating PRs that explain the sequence of commands required. |
Summary
Improve CMake performance by avoiding unnecessary regeneration of test files during repeated runs.
Problem
Currently, test files are generated unconditionally via the
p4_add_testsmacro every time CMake is executed. This leads to slower build configuration times, even when no relevant inputs have changed.Solution
Result
Notes