Centralize auto-label mappings into a configuration file#5658
Centralize auto-label mappings into a configuration file#5658Sanketjadhav31 wants to merge 3 commits into
Conversation
|
Thanks for the PR! As I just wrote in #5649, I don't think adding a configuration file is necessarily a good idea. Furthermore, in this PR, you still duplicate the labels with the same inconsistencies that #5649 seeks to abolish. I believe there is an idea worth pursuing here, so I encourage you to propose a different approach. |
Thanks for the feedback, @chreekat. I agree with the concerns about introducing a separate JSON configuration file. After reading your comments, I explored an alternative approach that keeps everything in JavaScript while separating the mapping data from the labeling logic. The idea is to:
Please check #5660 |
|
Thank you for the comments, @chreekat. I get your points on introducing a separate configuration file and on duplicating the mappings. I will revise my approach to keep all the things in JavaScript, declare the common mappings only once, and split the issue and PR mappings only where needed. I will adjust this PR accordingly. Thank you for your guidance! |
- Remove JSON configuration file and checkout step - Organize mappings into shared/issue-specific/PR-specific sections - Eliminate duplicate mappings (docs/documentation now shared) - Add missing labels: ebpf, ubpf, graphs - Normalize case for consistency (P4Testgen -> p4testgen) - Clearly separate data from logic per reviewer feedback - Preserve all original functionality and label targets Addresses maintainer feedback in PR p4lang#5658
efdf336 to
a431cd1
Compare
Signed-off-by: Sanketjadhav31 <sj546400@gmail.com>
- Remove JSON configuration file and checkout step - Organize mappings into shared/issue-specific/PR-specific sections - Eliminate duplicate mappings (docs/documentation now shared) - Add missing labels: ebpf, ubpf, graphs - Normalize case for consistency (P4Testgen -> p4testgen) - Clearly separate data from logic per reviewer feedback - Preserve all original functionality and label targets Addresses maintainer feedback in PR p4lang#5658 Signed-off-by: Sanketjadhav31 <sj546400@gmail.com>
Removed unnecessary comment sections from auto-label workflow. Signed-off-by: Sanket Jadhav <sj546400@gmail.com> Signed-off-by: Sanketjadhav31 <sj546400@gmail.com>
b65bc71 to
b4f1b8f
Compare
Summary
PR that extracts the auto-label mappings into the configuration file makes maintenance and expansion of the mappings easier.
Changes
.github/label-mappings.jsonthat serves as the source of mappings between issue/pull-request labels.[ebpf],[ubpf]and[graphs].Testing
Fixes #5649