Open
Conversation
Signed-off-by: An <aqnguyen96@gmail.com>
Signed-off-by: An <aqnguyen96@gmail.com>
Signed-off-by: An <aqnguyen96@gmail.com>
…fix comments/docs Signed-off-by: An <aqnguyen96@gmail.com>
df88920 to
b0b455b
Compare
Dscano
reviewed
Mar 26, 2026
| Congratulations, your implementation works! Move onto the next assignment | ||
| [Basic Tunneling](../basic_tunnel) | ||
|
|
||
| ## Automated Tests |
Contributor
There was a problem hiding this comment.
I would keep the Automated Tests section. It may not be the most interesting part from a learning perspective, but it is still valuable because it shows that the program is covered by tests.
Could you add a short descriptive sentence for this section? For example, you could explain that these automated tests are intended to support CI/CD, etc.
Contributor
|
@aqn96 overall, it looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses part of #103 issue (exercise 2 tests)
Adds automated PTF tests for the basic_tunnel exercise that run against solution/basic_tunnel.p4.
Included:
ptf/basic_tunnel.py — Seven tests
Ipv4DropOnMissTest — verifies plain IPv4 packets are dropped with no LPM table entries
Ipv4ForwardTest — verifies IPv4 forwarding with correct MAC rewrite and TTL decrement
TunnelForwardTest — verifies tunneled packets are forwarded correctly by dst_id
TunnelDropOnMissTest — verifies tunneled packets are dropped with no tunnel table entry
MixedTrafficTest — verifies IPv4 and tunnel traffic are handled independently
TunnelUnknownProtoTest — verifies tunnel forwarding is based solely on dst_id regardless of proto_id
TtlBoundaryTest — verifies TTL decrements correctly at boundary value
runptf.sh — compiles solution, starts simple_switch_grpc, runs PTF tests, cleans up
Makefile — adds make test target
.gitignore — excludes build artifacts and log files
test-exercises.yml — refactored CI to use matrix strategy, added concurrency and timeout. Used this as an example: https://github.com/p4lang/p4-dpdk-target/blob/main/.github/workflows/build_p4sde_ci.yml
Cleanup:
Test Result:
