Repository navigation
v1.5.0 - #140
Merged
Merged
v1.5.0#140
Conversation
- reuse compareWindowsById and drop the [...windows].sort() copy in planMerge - keep platform id and executable path in one record instead of a nested ternary - look up Chrome for Testing versions through a Map instead of a linear find per major - read the manifest minimum once per CLI run and share lock loading via readLock - remove type assertions that only silenced the compiler in tests
Align the codebase with the readable-code-review skill and its TypeScript optionals: no `as` used to silence the compiler, `const` over avoidable `let`, and shallow control flow. - check-dependencies: narrow JSON objects with a type guard instead of casting. - window-merge: replace the `let` + scan for an active tab with a named `const` lookup, flatten the planTabMoves if/else chain with guard clauses, and express filterWindows as one predicate. - merge-windows: iterate windows directly instead of building a flattened tab array. - browser tests: declare the chrome.developerPrivate API instead of casting `Reflect.get`, extract the management-page steps from the fixture, and pass a real tab to the action listeners. - ordering spec: build the case matrix once, extract setup, trigger, polling and assertions, and narrow window IDs with runtime checks.
- chrome window adapter: map+filter(isNotNull) became single-pass collectors, which also removes the isNotNull helper. - release script: build the remote tag map in one pass instead of filter(Boolean).map() over every ls-remote line. - ordering spec: look up merged tabs and groups through Maps instead of scanning per expected entry.
source-map-js 1.2.1 triggers GHSA-68fv-2mgg-jv7q and fails `check:dependencies`. Override it to 1.2.2, which is younger than minimumReleaseAge and only fixes that advisory. Also bump the catalog to the newest versions already older than minimumReleaseAge (10080 min).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary