added de-DE locale and autoloading in settings dialog#190
Open
a2800276 wants to merge 3 commits intopacexy:mainfrom
Open
added de-DE locale and autoloading in settings dialog#190a2800276 wants to merge 3 commits intopacexy:mainfrom
a2800276 wants to merge 3 commits intopacexy:mainfrom
Conversation
|
Someone is attempting to deploy a commit to the pacexy Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Pull request overview
This PR adds German (de-DE) locale support to the reader application. The author, a native German speaker, has created a comprehensive German translation file covering all UI strings in the application.
Changes:
- Added complete German locale file with translations for all application strings
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
remove trailing spaces at suggestion of copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corresponds to #189 :
I created a German language version (I am a native speaker), I've also modified the
settings.tsxUI to automatically load the available languages from thelocales/index.tsfile instead of hard coding them. Unfortunately, I was not able to do this for thenext.config.jsfile, where the available inter nationalizations are also hard-coded because of CommonJS / ES-Module conflicts that seem to complicated a.) to mix them into this relatively simple PR b.) are to complicated for my little brain to fully understand