Conversation
Allows callers to explicitly trigger a heartbeat check on a specific connection mode or all active connections, disconnecting on missed heartbeats so the next operation triggers a reconnect. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add heartbeat check counter to AmqpMockProvider to assert that _heartbeat() is actually invoked rather than short-circuited. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
fobilow
previously approved these changes
Mar 19, 2026
Add integration tests for GooglePubSubProvider against the PubSub emulator. Fix auto_create not working on gRPC transport - the code compared exception codes against HTTP status codes (404/409) but the Google Cloud PHP library passes gRPC codes (5/6) when using gRPC transport. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Docker entrypoint doesn't support multi-word commands as a single string. Run the emulator via docker run in a step with a health check wait. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
PubSub v2 requires the grpc extension to use the emulator - without it, the REST transport validates credentials before checking the emulator flag. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
PubSub v2 validates credentials before checking the emulator flag. Pass InsecureCredentials when PUBSUB_EMULATOR_HOST is set and no explicit credentials are configured. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bajb
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
heartbeat($connectionMode)method toAmqpQueueProviderthat explicitly checks heartbeat status on a specific connection or all active connectionsTest plan
testHeartbeat— verifies heartbeat on healthy connections does not trigger disconnecttestHeartbeatAfterMissed— verifies missed heartbeat triggers disconnect (requires RabbitMQ)🤖 Generated with Claude Code