-
Notifications
You must be signed in to change notification settings - Fork 22
Workflow glue #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Workflow glue #21
Conversation
Signed-off-by: Nikola Forró <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces workflow automation capabilities using Goose, Redis, and Ansible. It includes changes to the Makefile, Docker Compose configuration, environment variables, and Goose recipes. The changes add support for managing and executing workflows related to package rebase and issue analysis. The review identified areas for improvement in error handling, documentation, and clarity of instructions.
a925251 to
b11ab0d
Compare
In this way the recipe can be triggered, as an examples, from jobs taken from redis
b11ab0d to
d570bda
Compare
|
Looking at it, maybe we can just keep the PR open? Otherwise, we'll run into the game of running redis server etc and more. Just for prototyping with Goose, it's probably easier with the current main branch. |
|
WDYT? |
Right, the compose now has all the redis stuff. Sure, for me it is ok. |
|
I have to say that this feels like it is making the tech stack very big very quick. Do we need ansible here or could we keep it simpler? I'm also not sure that we want agents to be directly manipulating the work-queue through redis-mcp. We wouldn't have a human do that. Seems like it's going to invite ending up with corrupted JSON in there. |
I think we share the same thoughts. This PR was trying to figure out how we could glue multiple (goose) agents together. Part of the exercise is assessing the tools. Google's ADK may be better suited but let's see.
Agreed. We want/need "us" to do the DB manipulation, not an agent. |
When I was writing the bash script for checking/reading the database and executing the next goose recipe, it didn't feel readable or reliable to me. I personally prefer Ansible over bash scripts. As Valentin wrote, this was just a quick research prototype. As listed in the PR, I see several drawbacks and one advantage: the Ansible playbooks can easily be scaled in different ways in OpenShift if needed. If we ever go back to working with Ansible, I think we should investigate Ansible's async capabilities further. |
This is a "research" on how we can glue multiple agents with simple scripts + redis.
I tried bash, python and ansible. Ansible to me feels like the best fit.
Drawbacks from my point of view are:
Pros: