add review checklist inside newly created MRs as an internal note

[TomasTomecek]

You can verify you can't see the note: https://gitlab.com/TomasTomecek/centos_rpms_git-lfs/-/merge_requests/1

This is how it looks:

Fixes https://github.com/packit/jotnar/issues/188

[gemini-code-assist]

Code Review

This pull request introduces a helpful feature to automatically add a review checklist as an internal note to new merge requests. The implementation correctly distinguishes between new and existing MRs. My review focuses on several small but important formatting and content issues within the new checklist template that could affect its clarity and rendering. I've also pointed out a maintainability concern regarding the use of a private attribute to interact with the GitLab API, which could be made more robust.

[TomasTomecek]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a feature to add a review checklist as an internal note to newly created GitLab merge requests. The implementation is straightforward, using a flag to distinguish between new and existing MRs. My review includes suggestions to improve maintainability by externalizing the large checklist string, a caution about using private library attributes, and a recommendation to enhance test coverage to verify the note is not added to existing MRs. Overall, the changes are good and address the issue, but these improvements would make the code more robust and easier to maintain.

[nforro]

I would rather see this be returned from the tool, so that the agent code can detect a brand new MR was opened and call a generic comment-adding tool with the message. Implementing this here converts the tool from universal to single-task-specific.

[TomasTomecek]

okay

[nforro]

We could make the add_blocking_merge_request_comment tool more universal, accepting arguments such as internal or thread.

[TomasTomecek]

too late, already created a separate tool and task for that 😅

[nforro]

I suppose that's fine, since we have _get_merge_request_from_url() there is not that much code duplication.

[TomasTomecek]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a new feature to add a review checklist as an internal note to newly created merge requests. The changes are implemented across the backport and rebase agents, introducing a new workflow step and a corresponding task. The implementation is logical, but I've found a critical issue and a medium-severity issue related to incorrect type hints that need to be addressed. The most critical issue will cause a runtime error during a dry run due to an incorrect return value. I've left detailed comments with suggestions on how to fix these issues. Overall, this is a useful addition. Once the identified issues are resolved, the code should be ready to merge.

[TomasTomecek]

/gemini review

[gemini-code-assist]

Code Review

This pull request successfully implements the feature to add a review checklist as an internal note to newly created Merge Requests. The changes are well-integrated into the existing backport and rebase workflows, ensuring that the checklist is added only when an MR is newly created. The updates to function signatures, return types, and the PackageUpdateState model are consistent across the affected files. Unit tests have also been updated to reflect the new behavior. Overall, the changes are clean and effectively address the stated objective.