Add more instructions about fixing failing test during build #360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the prompt for the backport agent, providing more detailed instructions on how to handle build failures caused by failing tests. The changes are clear and well-structured, adding a new section for test failure considerations and updating existing rules. I have one suggestion to improve the consistency of the instructions for the agent.
| - The ONLY dist-git file you can modify is {{jira_issue}}.patch (by regenerating it from upstream repo) | ||
| - Fix build errors by adding missing prerequisites/dependencies to your patches in upstream repo | ||
| - Fix build errors (compilation AND test failures) by adding missing prerequisites/dependencies to your patches in upstream repo | ||
| - For test failures: backport minimal necessary test helpers/functions to make tests pass |
Contributor
There was a problem hiding this comment.
For consistency with the instruction on line 373, consider adding the word 'ONLY' here to emphasize that the agent should backport the minimal necessary helpers. This reinforces the instruction and can lead to more efficient and targeted fixes from the agent.
Suggested change
| - For test failures: backport minimal necessary test helpers/functions to make tests pass | |
| - For test failures: backport ONLY minimal necessary test helpers/functions to make tests pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.