Support compare URLs in extract_upstream_repository #366
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for parsing GitHub and GitLab compare URLs in extract_upstream_repository. The implementation correctly identifies the platform, makes the appropriate API calls to fetch commit lists, and includes a robust fallback mechanism. The changes are well-implemented. I've provided one suggestion to refactor a portion of the code to reduce duplication and improve maintainability.
opohorel
force-pushed
the
compare_url
branch
from
f6abb15 to
99d7d0f
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds support for extracting commit lists from GitHub/GitLab compare URLs. The changes involve extending the UpstreamRepository model, updating the tool's description, and adding new logic to parse compare URLs, fetch commit data from the respective APIs, and handle API failures gracefully. The implementation is solid, but I have a few suggestions to improve correctness and maintainability, mainly around URL encoding of parameters and refactoring the main method for clarity. I also noticed some code duplication that could be addressed.
opohorel
force-pushed
the
compare_url
branch
4 times, most recently
from
f2730ff to
86ef5d6
Compare
Fetch commit lists from compare URLs for cherry-pick workflow.
opohorel
force-pushed
the
compare_url
branch
from
86ef5d6 to
04c6412
Compare
2 participants
Fetch commit lists from compare URLs for cherry-pick workflow.