supervisor: Patch get_previous_erratum logic #372
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function used to fetch the Erratum object after it found the previous
erratum. However, we encountered an edge case that the erratum_id from the
erratatools API's response of
<endpoint>/api/v1/product_versions/{RHEL version}/released_builds/{package name}
cound be null in REHL 8. To address this, we decide to make this function just
return the erratum id and build nvr so we can decide whether we should fetch the
Erratum object or not after calling this function.
Also adjust the logic where this function is called.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the get_previous_erratum function to handle an edge case where an erratum ID from the API can be null. The function now returns the erratum ID and build NVR as a tuple, deferring the decision to fetch the full Erratum object to the caller. The changes are correctly propagated to the call sites in erratum_handler.py and issue_handler.py.
My review includes a couple of suggestions to improve maintainability and readability. One suggestion is to refactor a block of code in errata_utils.py for conciseness and to use safer dictionary access. Another suggestion is to centralize the construction of errata advisory URLs to avoid hardcoding them in multiple places.
Adds get_erratum_advisory_url, removes trailing slash from ET_URL, and updates erratum URL construction across the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function used to fetch the Erratum object after it found the previous erratum. However, we encountered an edge case that the erratum_id from the erratatools API's response of
/api/v1/product_versions/{RHEL version}/released_builds/{package name}
cound be null in REHL 8. To address this, we decide to make this function just return the erratum id and build nvr so we can decide whether we should fetch the Erratum object or not after calling this function.
Also adjust the logic where this function is called.