Implement support for Forgejo releases and tags #903

olamidepeterojo · 2025-03-20T02:18:29Z

TODO:

Write new tests or update the old ones to cover new functionality.
Update doc-strings where appropriate.
Update or write new documentation in packit/packit.dev.
‹fill in›

Fixes #881

Related to #866

Merge before/after

RELEASE NOTES BEGIN

Packit now supports automatic ordering of ☕ after all checks pass.

RELEASE NOTES END

softwarefactory-project-zuul · 2025-03-20T02:22:01Z

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/07cacf49710546308a63acdbaa702266

✔️ pre-commit SUCCESS in 2m 48s
❌ ogr-tests-pip-deps FAILURE in 1m 56s

softwarefactory-project-zuul · 2025-03-26T22:03:26Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/cf86a2981dec4b73b92a6ffe4894dd4c

✔️ pre-commit SUCCESS in 2m 39s
✔️ ogr-tests-pip-deps SUCCESS in 17m 39s

lbarcziova

hello and thanks for the contribution! Mostly the same comments as in #902 apply here, please ideally play with the code a bit locally e.g. by creating your own test repo in https://codeberg.org and once you verify the code works, let us know and we can review it. As for tests, we are using requre for recording the test responses and the contribution guide and the README can help.

lbarcziova · 2025-04-07T13:39:32Z

ogr/services/forgejo/release.py

+        name: Optional[str] = None,
+        tag_name: Optional[str] = None,
+    ) -> "Release":
+        client = PyforgejoApi(api_url=project.forge_api_url, token=project.token)


instead of initialising the client multiple times, you could create a property, you can get inspired or even use this and this

lbarcziova · 2025-04-07T13:42:41Z

tests/integration/forgejo/conftest.py

+@pytest.fixture
+def project(service):
+    repo = os.environ.get("FORGEJO_REPO", "existing_repo_name")
+    namespace = os.environ.get("FORGEJO_NAMESPACE", "existing_namespace")
+    project = service.get_project(
+        repo=repo,
+        namespace=namespace,
+    )
+    if project is None:
+        pytest.skip(f"Project {namespace}/{repo} not found.")
+    return project


the code has been updated in the meantime, can you please use the properties project or hello_world_project that were added and run the tests using those?

lbarcziova · 2025-04-07T13:45:09Z

ogr/services/forgejo/release.py

+            api_url=self.project.forge_api_url,
+            token=self.project.token,
+        )
+        # Assume the SDK provides a method to download the tarball.


next time please double-check the assumptions, this method doesn't exist 😄

and actually the save_archive method doesn't need to be implemented, it is implemented in the base.py, and checking the usage I don't see any, so we should maybe clean this up even

lbarcziova · 2025-04-07T13:47:00Z

ogr/services/forgejo/release.py

+        return f"GitTag(name={self.name}, commit_sha={self.commit_sha})"
+
+
+class ForgejoGitTag(GitTag):


the classes should inherit from the classes in abstract.py

olamidepeterojo · 2025-04-09T13:46:23Z

hello and thanks for the contribution! Mostly the same comments as in #902 apply here, please ideally play with the code a bit locally e.g. by creating your own test repo in https://codeberg.org and once you verify the code works, let us know and we can review it. As for tests, we are using requre for recording the test responses and the contribution guide and the README can help.

Thank you so much for the feedback! 🙏🏽 I’ve gone through your comments and I really appreciate the guidance.

I was able to do some local testing using a test repo on Codeberg as suggested and I’ve verified that the release creation works as expected. I'm looking forward to your review

softwarefactory-project-zuul · 2025-04-09T14:10:05Z

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/62d7e3ac905d44b0a29b926fbdd0cc20

❌ pre-commit FAILURE in 3m 47s
❌ ogr-tests-pip-deps FAILURE in 17m 30s

softwarefactory-project-zuul · 2025-04-10T11:18:27Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/18ce23b9197c46c9abdb1aa02ad8ca68

✔️ pre-commit SUCCESS in 3m 44s
✔️ ogr-tests-pip-deps SUCCESS in 17m 28s

lbarcziova · 2025-04-10T14:07:59Z

ogr/services/forgejo/release.py

+        client = ForgejoRelease.get_api(project)
+        releases_data = client.get_releases(owner=project.owner, repo=project.repo)


could you please provide a reference where did you get this from? This doesn't work for me and I don't see any method like that in the client repo..

Thanks for pointing that out. I just checked and it was my mistake

lbarcziova · 2025-04-10T14:08:54Z

ogr/services/forgejo/release.py

+    """
+
+    @cached_property
+    def api(self) -> PyforgejoApi:


we should be reusing the authenticated API client from the ForgejoProject class

Signed-off-by: Olamidepeterojo <[email protected]>

softwarefactory-project-zuul · 2025-04-10T22:22:04Z

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/67ad811825b84f9784dd2651923cf39f

✔️ pre-commit SUCCESS in 3m 41s
✔️ ogr-tests-pip-deps SUCCESS in 17m 31s

olamidepeterojo · 2025-04-13T12:58:54Z

Hello @lbarcziova, I would like your guidance in the section that has to do with "Outreachy internship project timeline" .

lbarcziova · 2025-05-27T09:27:07Z

Hi! Thanks a lot for the contribution, as this work became a priority for us, this was implemented in #927, therefore closing.

olamidepeterojo force-pushed the forgejo_release branch from bc9b078 to 9d5d9b6 Compare March 26, 2025 21:45

lbarcziova reviewed Apr 7, 2025

View reviewed changes

olamidepeterojo force-pushed the forgejo_release branch from 9d5d9b6 to 129f704 Compare April 9, 2025 13:49

olamidepeterojo marked this pull request as draft April 9, 2025 21:46

olamidepeterojo force-pushed the forgejo_release branch from d055865 to 9566143 Compare April 10, 2025 11:00

olamidepeterojo marked this pull request as ready for review April 10, 2025 11:18

olamidepeterojo requested a review from lbarcziova April 10, 2025 11:18

lbarcziova reviewed Apr 10, 2025

View reviewed changes

Implement support for Forgejo releases and tags

1dcd955

Signed-off-by: Olamidepeterojo <[email protected]>

olamidepeterojo force-pushed the forgejo_release branch from 9566143 to 1dcd955 Compare April 10, 2025 22:03

olamidepeterojo requested a review from lbarcziova April 10, 2025 22:04

lbarcziova closed this May 27, 2025

		return f"GitTag(name={self.name}, commit_sha={self.commit_sha})"


		class ForgejoGitTag(GitTag):

		client = ForgejoRelease.get_api(project)
		releases_data = client.get_releases(owner=project.owner, repo=project.repo)

Implement support for Forgejo releases and tags #903

Implement support for Forgejo releases and tags #903

Uh oh!

Conversation

olamidepeterojo commented Mar 20, 2025

Uh oh!

softwarefactory-project-zuul bot commented Mar 20, 2025

Uh oh!

softwarefactory-project-zuul bot commented Mar 26, 2025

Uh oh!

lbarcziova left a comment

Choose a reason for hiding this comment

Uh oh!

lbarcziova Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

lbarcziova Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

lbarcziova Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

lbarcziova Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

olamidepeterojo commented Apr 9, 2025

Uh oh!

softwarefactory-project-zuul bot commented Apr 9, 2025

Uh oh!

softwarefactory-project-zuul bot commented Apr 10, 2025

Uh oh!

lbarcziova Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

olamidepeterojo Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

lbarcziova Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

softwarefactory-project-zuul bot commented Apr 10, 2025

Uh oh!

olamidepeterojo commented Apr 13, 2025

Uh oh!

lbarcziova commented May 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants