Skip to content

Conversation

@jpopelka
Copy link
Member

@jpopelka jpopelka commented May 6, 2022

TODO:

  • Write new tests or update the old ones to cover the new functionality.

I need this for hardly, where we want to react when a source-git MR gets closed.

@softwarefactory-project-zuul

This comment was marked as outdated.

@jpopelka jpopelka force-pushed the gitlab-mr-close branch from 337d7a9 to c3e3d92 Compare May 9, 2022 08:07
@softwarefactory-project-zuul

This comment was marked as outdated.

@jpopelka jpopelka force-pushed the gitlab-mr-close branch from c3e3d92 to d6abb29 Compare May 9, 2022 10:21
@softwarefactory-project-zuul

This comment was marked as outdated.

@jpopelka jpopelka force-pushed the gitlab-mr-close branch from d6abb29 to 0cfb347 Compare May 9, 2022 10:32
@softwarefactory-project-zuul

This comment was marked as outdated.

@jpopelka jpopelka force-pushed the gitlab-mr-close branch from 0cfb347 to 0e13ee1 Compare May 9, 2022 11:17
@softwarefactory-project-zuul

This comment was marked as outdated.

Copy link
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, and I wondered how come it has +297 -56 while it seemed like an easy PR

90% is tech debt, nice! :)

@jpopelka jpopelka force-pushed the gitlab-mr-close branch from 0e13ee1 to ee42755 Compare May 9, 2022 15:08
@softwarefactory-project-zuul

This comment was marked as outdated.

jpopelka added 4 commits May 10, 2022 09:37
if one wants to use their local base image.
I need this for hardly, where we want to react when a source-git MR gets closed.
packit/hardly#62
@jpopelka jpopelka added the mergeit Merge via Zuul label May 10, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ pre-commit SUCCESS in 2m 30s
✔️ packit-service-tests SUCCESS in 2m 21s
✔️ packit-service-tests-openshift SUCCESS in 14m 17s

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ pre-commit SUCCESS in 3m 13s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 858f7b0 into packit:main May 10, 2022
@jpopelka jpopelka deleted the gitlab-mr-close branch May 10, 2022 07:59
softwarefactory-project-zuul bot added a commit to packit/hardly that referenced this pull request May 10, 2022
Sync to dist-git MR when source-git MR has been closed or reopened

Test on staging - seems to work OK



Fixes

#35
#47

Merge after

packit/packit-service#1492
packit/ogr#714 (probably won't wait for it since it's blocked on Pagure)

Reviewed-by: Tomas Tomecek <[email protected]>
Reviewed-by: Jiri Popelka <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mergeit Merge via Zuul

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants