Skip to content

Conversation

@lbarcziova
Copy link
Member

@lbarcziova lbarcziova commented Oct 24, 2024

Fixes #2579

Related to packit/packit-service-fedmsg#115
Related to packit/deployment#608

RELEASE NOTES BEGIN

N/A

RELEASE NOTES END

@lbarcziova lbarcziova requested a review from a team as a code owner October 24, 2024 08:30
@softwarefactory-project-zuul
Copy link
Contributor

Copy link
Member

@nforro nforro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@softwarefactory-project-zuul
Copy link
Contributor

logger.debug(f"Base project: {fork} owned by {self.base_repo_owner}")
return fork

def get_packages_config(self) -> Optional[PackageConfig]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 Do we have both project × get_project and packages_config × get_packages_config? /o\

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I fear :D

@lbarcziova lbarcziova added the mergeit Merge via Zuul label Oct 24, 2024
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/654a9fe8f6244725913840a92012ad41

✔️ pre-commit SUCCESS in 2m 08s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a72fc6b into packit:main Oct 24, 2024
4 checks passed
@lbarcziova lbarcziova deleted the pagure-pr branch October 24, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mergeit Merge via Zuul

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Parse the dist-git PR events

3 participants