Skip to content

Add OpenScanHub integration with Fedora CI #2762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
siteshwar wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Add OpenScanHub integration with Fedora CI #2762

siteshwar wants to merge 7 commits into from

Conversation

@siteshwar
Copy link
Contributor

@siteshwar siteshwar commented Mar 25, 2025

TODO:

  • Write new tests or update the old ones to cover new functionality.
  • Update doc-strings where appropriate.
  • Update or write new documentation in packit/packit.dev.

Fixes

Related to

Merge before/after

RELEASE NOTES BEGIN

RELEASE NOTES END

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 25, 2025

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/223bc07309ed46db81f7d06cf9edb583

❌ pre-commit FAILURE in 1m 48s
❌ packit-service-tests FAILURE in 1m 10s

@siteshwar
Copy link
Contributor Author

siteshwar commented Mar 25, 2025

As of now, this pull request contains some non-functional code and there may be some code duplication. But I am opening it to stay in sync with the Packit team about how these changes should work overall.

@siteshwar siteshwar force-pushed the openscanhub-fedora-ci-prototype branch from 5c3debf to 9b7c112 Compare March 25, 2025 13:10
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 25, 2025

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/0a9de69ec7b54702a83d9cd9020b5a66

❌ pre-commit FAILURE in 1m 54s
❌ packit-service-tests FAILURE in 1m 11s

@siteshwar siteshwar force-pushed the openscanhub-fedora-ci-prototype branch from 9b7c112 to bb34f43 Compare March 25, 2025 14:03
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 25, 2025

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/45b21ecbe98644868a798310e90e184a

❌ pre-commit FAILURE in 1m 52s
✔️ packit-service-tests SUCCESS in 2m 38s

nforro
nforro reviewed Mar 25, 2025
View reviewed changes
nforro
nforro reviewed Mar 25, 2025
View reviewed changes
nforro
nforro reviewed Mar 25, 2025
View reviewed changes
@siteshwar siteshwar force-pushed the openscanhub-fedora-ci-prototype branch from bb34f43 to fda19a3 Compare March 26, 2025 09:18
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 26, 2025

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/c0053936404e4c4a99900de02d54c831

❌ pre-commit FAILURE in 1m 55s
❌ packit-service-tests FAILURE in 1m 09s

@siteshwar siteshwar force-pushed the openscanhub-fedora-ci-prototype branch from fda19a3 to f1b8a13 Compare March 26, 2025 09:25
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 26, 2025

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/68b5104caf0d4002bef6cd281e551fad

❌ pre-commit FAILURE in 1m 48s
❌ packit-service-tests FAILURE in 1m 07s

@siteshwar siteshwar force-pushed the openscanhub-fedora-ci-prototype branch from f1b8a13 to c61be0d Compare March 26, 2025 09:45
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 26, 2025

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/f93d9d1202f243bca59fcddb85eb7ea7

✔️ pre-commit SUCCESS in 1m 54s
❌ packit-service-tests FAILURE in 1m 10s

@siteshwar siteshwar force-pushed the openscanhub-fedora-ci-prototype branch 2 times, most recently from 3dab40e to 8a81e34 Compare March 26, 2025 09:53
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 26, 2025

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/58cd1415120e4961b44de9b964fa22fb

✔️ pre-commit SUCCESS in 1m 50s
❌ packit-service-tests FAILURE in 1m 04s

@siteshwar siteshwar force-pushed the openscanhub-fedora-ci-prototype branch 2 times, most recently from dd19533 to 231eebf Compare March 26, 2025 10:07
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 26, 2025

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/138ab2d76abd45689bc4b3c4d536136d

✔️ pre-commit SUCCESS in 1m 51s
❌ packit-service-tests FAILURE in 1m 07s

@siteshwar siteshwar force-pushed the openscanhub-fedora-ci-prototype branch from 231eebf to 58675d6 Compare March 26, 2025 12:41
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 26, 2025

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/e8d31ccb53f649df95f2aa1909ff5653

✔️ pre-commit SUCCESS in 1m 51s
✔️ packit-service-tests SUCCESS in 2m 38s

@siteshwar
Copy link
Contributor Author

siteshwar commented Mar 26, 2025

The checks are passing now, so I am marking this pull request ready for review. There may still be some missing code, but I would not know it until these changes gets reviewed by others and deployed to staging. Thanks @nforro for reviewing the draft.

@siteshwar siteshwar marked this pull request as ready for review March 26, 2025 13:03
@siteshwar siteshwar requested a review from a team as a code owner March 26, 2025 13:03
nforro
nforro reviewed Mar 26, 2025
View reviewed changes
@siteshwar siteshwar force-pushed the openscanhub-fedora-ci-prototype branch from 58675d6 to 38b2911 Compare March 26, 2025 13:31
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Mar 26, 2025

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/7a99d20ac83d49d99f3c859e574335e3

✔️ pre-commit SUCCESS in 1m 53s
✔️ packit-service-tests SUCCESS in 2m 56s

@siteshwar
Add KojiOpenScanHubHelper and refactor some code
07d4c91 
... to download SRPMs to make it reusable.

Signed-off-by: Siteshwar Vashisht <[email protected]>
@siteshwar
Refactor handler for OpenScanHub and Copr
dbbd963 
... to make some code reusable for Koji builds.

Signed-off-by: Siteshwar Vashisht <[email protected]>
@siteshwar siteshwar force-pushed the openscanhub-fedora-ci-prototype branch from 38b2911 to cf9f324 Compare April 16, 2025 21:15
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Apr 16, 2025

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/8c2ca72e3e964a3ab6af7c5794224cb2

✔️ pre-commit SUCCESS in 1m 50s
✔️ packit-service-tests SUCCESS in 3m 10s

@siteshwar
Copy link
Contributor Author

siteshwar commented Apr 16, 2025

// Self Notes

Integration test example: https://github.com/packit/packit-service/blob/11d4722765650d350cab89ba8ec80fcfd0736cfa/tests/integration/test_listen_to_fedmsg.py
Unit test example: https://github.com/packit/packit-service/blob/11d4722765650d350cab89ba8ec80fcfd0736cfa/tests/unit/test_open_scan_hub.py

@siteshwar siteshwar force-pushed the openscanhub-fedora-ci-prototype branch from cf9f324 to 90c1122 Compare April 16, 2025 23:30
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Apr 16, 2025

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/50a3f77b0a2d483d8a8f4ada4e3ccb48

✔️ pre-commit SUCCESS in 1m 48s
✔️ packit-service-tests SUCCESS in 2m 59s

@siteshwar siteshwar force-pushed the openscanhub-fedora-ci-prototype branch from 90c1122 to adf3a9b Compare April 17, 2025 01:32
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Apr 17, 2025

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/42f0d285f8764718828cf30350c4158c

❌ pre-commit FAILURE in 1m 52s
❌ packit-service-tests FAILURE in 2m 52s

@siteshwar siteshwar force-pushed the openscanhub-fedora-ci-prototype branch from 2519619 to 5abe74e Compare April 17, 2025 01:43
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Apr 17, 2025

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/715c7f0c814d44f29d4d5b1f72634084

✔️ pre-commit SUCCESS in 1m 51s
❌ packit-service-tests FAILURE in 3m 02s

@siteshwar siteshwar force-pushed the openscanhub-fedora-ci-prototype branch from 5abe74e to 854e1cf Compare April 17, 2025 02:01
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Apr 17, 2025

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/ef88d19e5a8b4ce29039f4bac95959a9

✔️ pre-commit SUCCESS in 1m 53s
❌ packit-service-tests FAILURE in 2m 56s

@siteshwar
Add koji related fields to OSHScanModel
11b178f 
Signed-off-by: Siteshwar Vashisht <[email protected]>
@siteshwar
Add handler for OpenScanHub and Koji builds
094308a 
Signed-off-by: Siteshwar Vashisht <[email protected]>
@siteshwar
Trigger OpenScanHub scans on Koji builds
179e4a9 
Signed-off-by: Siteshwar Vashisht <[email protected]>
@siteshwar
Allow using KojiBuildTargetModel with OpenScanHub
a07361f 
... related events.

Signed-off-by: Siteshwar Vashisht <[email protected]>
@siteshwar
Add tests for OpenScanHub Koji integration
4951fb5 
Signed-off-by: Siteshwar Vashisht <[email protected]>
@siteshwar siteshwar force-pushed the openscanhub-fedora-ci-prototype branch from 854e1cf to 4951fb5 Compare April 18, 2025 22:37
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Apr 18, 2025

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/24fb49987da24a7faea7866dcbf3e24e

✔️ pre-commit SUCCESS in 1m 55s
❌ packit-service-tests FAILURE in 3m 11s

@siteshwar siteshwar mentioned this pull request Apr 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nforro nforro nforro left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@siteshwar @nforro