[WIP] feat: Filter copr_build jobs based on paths and files changed

[LecrisUT]

TODO:

• Skip the check if /packit command is used
• Actually check the files changed
• Write new tests or update the old ones to cover new functionality.
• Update or write new documentation in packit/packit.dev.

Fixes packit/packit#1997
Fixes #2006

RELEASE NOTES BEGIN

copr_build jobs are triggered only if there are changed files under the paths field

RELEASE NOTES END

[LecrisUT]

Currently stuck on this part. Isn't the git repo cloned somewhere when the package_config was evaluated? I was hoping on using that to do the git diff, but I haven't navigated to such a part. Should that be an interface in ogr instead?

[nforro]

LocalProjectMixin should give you self.local_project.git_repo which is git.Repo.

packit-service/packit_service/worker/mixin.py

Lines 212 to 246 in 11d4722

	class LocalProjectMixin(Config):
	_local_project: Optional[LocalProject] = None
	@property
	def local_project(self) -> LocalProject:
	if not self._local_project:
	builder = LocalProjectBuilder(
	cache=(
	RepositoryCache(
	cache_path=self.service_config.repository_cache,
	add_new=self.service_config.add_repositories_to_repository_cache,
	)
	if self.service_config.repository_cache
	else None
	),
	)
	working_dir = Path(
	Path(self.service_config.command_handler_work_dir) / SANDCASTLE_LOCAL_PROJECT_DIR,
	)
	kwargs = {
	"repo_name": CALCULATE,
	"full_name": CALCULATE,
	"namespace": CALCULATE,
	"working_dir": working_dir,
	"git_repo": CALCULATE,
	}
	if self.project:
	kwargs["git_project"] = self.project
	else:
	kwargs["git_url"] = self.project_url
	self._local_project = builder.build(**kwargs)
	return self._local_project

[lbarcziova]

on our arch meeting we were discussing we could get this rather via API, this would mean implementing the method for getting a commit in ogr

[LecrisUT]

Can go either way on LocalProject vs ogr

ogr

pro

• easier interface
• don't have to deal with fork fetches

con

• it downloads the diff content thatis ignored
• may be slower and rate limited because it goes through web api

LocalProject

pro

• already used by osh (didn't check if we would be reusing it though)
• still downloads the diffs, but it's more efficient at that
• no rate/file limits

con

• handling PRs is a bit clunky
• if the git is not cached it could be more expensive to re-clone the project every time

---

I am leaning towards the ogr approach. What's your thoughts on the choice of these 2?

[lbarcziova]

+1 for the ogr/API approach, we would be checking this only if this is configured in the config, so I believe it would not be such a big additional API load in the end, and sounds more straightforward; I don't like cloning the repo already in the pre-check that much

[softwarefactory-project-zuul]

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/d8df73178934488f99f72ae42d7d9818

❌ pre-commit FAILURE in 1m 48s
❌ packit-service-tests FAILURE in 3m 31s

[softwarefactory-project-zuul]

Build failed.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/ccd7ecf77cb44d22b2ccb47800d4a1e9

✔️ pre-commit SUCCESS in 1m 52s
❌ packit-service-tests FAILURE in 3m 22s