Implement installability check for Packit as a Fedora dist-git CI #2782
Conversation
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 57s |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 51s |
Signed-off-by: Nikola Forró <[email protected]>
Signed-off-by: Nikola Forró <[email protected]>
Signed-off-by: Nikola Forró <[email protected]>
Signed-off-by: Nikola Forró <[email protected]>
Signed-off-by: Nikola Forró <[email protected]>
Signed-off-by: Nikola Forró <[email protected]>
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 54s |
| method: Optional[str] = None, | ||
| params: Optional[dict] = None, | ||
| data: Optional[dict] = None, | ||
| ) -> RequestResponse: | ||
| method = method or "GET" |
There was a problem hiding this comment.
| method: Optional[str] = None, | |
| params: Optional[dict] = None, | |
| data: Optional[dict] = None, | |
| ) -> RequestResponse: | |
| method = method or "GET" | |
| method: str = "GET", | |
| params: Optional[dict] = None, | |
| data: Optional[dict] = None, | |
| ) -> RequestResponse: |
| We need to get more details ourselves.""" | ||
| service_config = ServiceConfig.get_service_config() | ||
| self = cls( | ||
| api_url=service_config.testing_farm_api_url, |
There was a problem hiding this comment.
I guess it's coming from the original code, but could you add a comment here? It feels like we can't tell apart… oh never mind, the API is public for both public and RH ranch 🤦
guess it deserves a comment anyways :D
Fixes #2712.
RELEASE NOTES BEGIN
Installability check is now being run as part of CI on dist-git pull requests.
RELEASE NOTES END