Skip to content

Add a dist-git-branch context #2935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LecrisUT wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a dist-git-branch context #2935

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packit_service/worker/helpers/testing_farm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1515,6 +1515,7 @@ def _get_tf_base_payload(self, distro: str, compose: Optional[str]) -> dict:
# this has to be specified at the api request level.
# TODO: Revisit when 0.2 testing-farm API is decided
os_params = {"os": {"compose": compose}} if compose else {}
dist_git_branch = self.project.get_pr(self.metadata.pr_id).target_branch
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This call to self.project.get_pr(self.metadata.pr_id) makes a network request. Since _get_tf_base_payload can be called multiple times within a single job run (e.g., for rpminspect and custom tests), this can lead to redundant API calls.

To improve efficiency, I suggest caching the pull request object on the helper instance. This ensures the PR is fetched only once per job run.

I've also noticed that _payload_custom makes a similar call. After applying this suggestion, you could refactor it to use the cached self._pr_object as well.

        if not hasattr(self, "_pr_object"):
            self._pr_object = self.project.get_pr(self.metadata.pr_id)
        dist_git_branch = self._pr_object.target_branch

return {
"environments": [
{
Expand All @@ -1532,6 +1533,7 @@ def _get_tf_base_payload(self, distro: str, compose: Optional[str]) -> dict:
"arch": "x86_64",
"trigger": "commit",
"initiator": "fedora-ci",
"dist-git-branch": dist_git_branch,
}
},
},
Expand Down
Loading