Simplify fedora-ci jobs#3097
Conversation
|
❌ pre-commit FAILURE in 1m 55s |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the _payload_installability method in testing_farm.py to utilize a base payload helper, which simplifies the logic by removing manual environment configuration and dynamic reference fetching. Feedback was provided to replace hardcoded repository details with existing constants to ensure consistency and improve maintainability.
LecrisUT
force-pushed
the
chore/simplify-fedora-ci
branch
from
48a81ac to
4a195e9
Compare
|
❌ pre-commit FAILURE in 2m 15s |
LecrisUT
force-pushed
the
chore/simplify-fedora-ci
branch
from
4a195e9 to
b1b883f
Compare
|
✔️ pre-commit SUCCESS in 1m 52s |
|
✔️ pre-commit SUCCESS in 1m 53s |
LecrisUT
force-pushed
the
chore/simplify-fedora-ci
branch
from
8f28963 to
da637ff
Compare
|
✔️ pre-commit SUCCESS in 1m 53s |
LecrisUT
force-pushed
the
chore/simplify-fedora-ci
branch
from
da637ff to
74e6732
Compare
|
✔️ pre-commit SUCCESS in 1m 50s |
LecrisUT
force-pushed
the
chore/simplify-fedora-ci
branch
from
74e6732 to
da1bef5
Compare
|
✔️ pre-commit SUCCESS in 1m 55s |
LecrisUT
force-pushed
the
chore/simplify-fedora-ci
branch
from
da1bef5 to
e2a156b
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 53s |
|
https://artifacts.dev.testing-farm.io/53027160-0548-4339-bf40-2983a0c026d2/ should be an equivalent job that goes through the new api |
mfocko
left a comment
mfocko
left a comment
There was a problem hiding this comment.
LGTM, as long as it works. Which I can't really tell. There's also no justification for the changes.
Could you please link the relevant ticket (and possibly also changes) in the commit? Also please squash, I'd prefer to keep this atomic (changes + tests).
LecrisUT
force-pushed
the
chore/simplify-fedora-ci
branch
from
e2a156b to
6cafc40
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 53s |
Not sure which ticket to include, there are 3 of them(https://forge.fedoraproject.org/ci/tickets/issues/553, fedora-ci/installability-pipeline#63, fedora-ci/installability-pipeline#64)
Previous comment has a testing-farm job running with these variables
Basically all Fedora-CI jobs will expect and use the set of variables that packit provides. This is a prerequisite for #2914 and #2990 |
LecrisUT
force-pushed
the
chore/simplify-fedora-ci
branch
from
6cafc40 to
b53868b
Compare
|
✔️ pre-commit SUCCESS in 1m 47s |
LecrisUT
force-pushed
the
chore/simplify-fedora-ci
branch
from
b53868b to
cddb32c
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 48s |
Well, ideally all of them then :) sorry about annoying you with that, but it's better to have it in history than be in the dark when it's needed
cool, thanks!
👍 |
All Fedora-CI jobs use consistent variables that Packit already provides in `_get_tf_base_payload` For more context: - https://forge.fedoraproject.org/ci/tickets/issues/553 - fedora-ci/installability-pipeline#63 - fedora-ci/installability-pipeline#64 Signed-off-by: Cristian Le <git@lecris.dev>
Eventually the tests should use the repo created by the artifacts and multihost pipeline, but these are not ready to do so yet Signed-off-by: Cristian Le <git@lecris.dev>
LecrisUT
force-pushed
the
chore/simplify-fedora-ci
branch
from
cddb32c to
87fe85a
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 53s |
3 participants
As part of the cleanup of the current fedora-ci jobs https://forge.fedoraproject.org/ci/tickets/issues/553, the interface for all of these jobs would converge to that from packit, simplifying how the jobs are handled here.
TODO:
dist-git-branchfedora-ci/installability-pipeline#63