Add documentation regarding new functionality of packit init #1056
Conversation
|
Build failed. ❌ pre-commit FAILURE in 1m 14s |
|
pre-commit.ci autofix |
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 13s |
betulependule
requested review from
majamassarini
and removed request for
majamassarini
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 15s |
betulependule
force-pushed
the
packit-init-flag
branch
from
b8fa136 to
68cc38b
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 14s |
betulependule
force-pushed
the
packit-init-flag
branch
from
e3015a4 to
f0042a7
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 11s |
betulependule
force-pushed
the
packit-init-flag
branch
from
f0042a7 to
d9cae67
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 15s |
betulependule
force-pushed
the
packit-init-flag
branch
from
d9cae67 to
54f4043
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 15s |
mfocko
left a comment
mfocko
left a comment
There was a problem hiding this comment.
Except for the one typo, LGTM.
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 19s |
|
pre-commit passed, but you still need to rebase @betulependule |
Documentation now describes new requirements connected to the functionality that automatically adds packit-specific pre-commit check that validates .packit.yaml. Requirements are: 1. Working directory be a git repo 2. Pre-commit configuration file must be present A new flag was also added, which causes packit init to automatically create pre-commit configuration file in case it is missing.
betulependule
force-pushed
the
packit-init-flag
branch
from
38885ad to
93db18e
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 19s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 14s |
softwarefactory-project-zuul
bot
merged commit a2d7054
into
packit:main
2 participants
Documentation now describes new requirements connected to the functionality of
packit initthat automatically adds a packit-specific pre-commit hook that validates.packit.yamlto the user's pre-commit onfiguration file (skipped if pre-commit configuration file is not present). Two new flags were also edit to modify this behavior:--force-precommit: initializes an empty pre-commit onfiguration file if missing and adds aforementioned pre-commit hook--without-precommit: skips this pre-commit-related behaviorRelated to #2641
Merge at the same time as #2641