Skip to content

Conversation

@usercont-release-bot
Copy link

Automatically regenerated help messages for CLI command docs.

@softwarefactory-project-zuul
Copy link
Contributor

@softwarefactory-project-zuul
Copy link
Contributor

@softwarefactory-project-zuul
Copy link
Contributor

@softwarefactory-project-zuul
Copy link
Contributor

@softwarefactory-project-zuul
Copy link
Contributor

@softwarefactory-project-zuul
Copy link
Contributor

@softwarefactory-project-zuul
Copy link
Contributor

Comment on lines +36 to +38
--without_precommit Skip adding packit-specific pre-commit configuration
hook.
--force_precommit Create pre-commit configuration file if missing.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@betulependule I guess it got merged with the underscores anyways 👀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I completely missed these errors. 👀 I'll fix the other instances where dashes need to be replaced with underscores in this PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the underscores where intentional? 👀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can push new commits to this PR, right? 😅

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's auto-generated, if you're going to adjust this specific section (the help for init), it will get overwritten next week anyways :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I took a look at the code and underscores are being used. 😅
I can make a new PR and change it in Packit to dashes if that would be better.

https://github.com/packit/packit/blob/f1ebbe077647d8d70f3821126a7839d0f386b5b3/packit/cli/init.py#L44-L55

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better for the consistency with other options :/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, tomorrow I'll make a new issue and fix it in Packit. 👍

@softwarefactory-project-zuul
Copy link
Contributor

@softwarefactory-project-zuul
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants