-
Notifications
You must be signed in to change notification settings - Fork 18
Research rebase vs. backport decision #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| - check past issues to see if the package is usually rebased, if the fixes are usually backported, | ||
| or a combination of both, and suggest a way to proceed based on that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is an excellent point
| - perform the rebase anyway, do a scratch build and provide results of abidiff check | ||
| and output of reverse dependency tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in theory, we could do both and let the maintainer decide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uh, you suggest this below :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you see a value in doing some of the checks beforehand, I assume some license change check, also the ABI/API, comparing the CVEs present in both versions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you see a value in doing some of the checks beforehand, I assume some license change check, also the ABI/API, comparing the CVEs present in both versions?
You mean doing the checks on upstream sources? Sure, what would have some value, but the more downstream patches the less trustworthy it would be.
c9d3933 to
9f3c60f
Compare
Signed-off-by: Nikola Forró <[email protected]>
TomasTomecek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, very nice writeup, let's merge
No description provided.