Skip to content

Conversation

@nforro
Copy link
Member

@nforro nforro commented Jun 19, 2025

No description provided.

Comment on lines +13 to +14
- check past issues to see if the package is usually rebased, if the fixes are usually backported,
or a combination of both, and suggest a way to proceed based on that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an excellent point

Comment on lines +17 to +18
- perform the rebase anyway, do a scratch build and provide results of abidiff check
and output of reverse dependency tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in theory, we could do both and let the maintainer decide

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh, you suggest this below :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you see a value in doing some of the checks beforehand, I assume some license change check, also the ABI/API, comparing the CVEs present in both versions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you see a value in doing some of the checks beforehand, I assume some license change check, also the ABI/API, comparing the CVEs present in both versions?

You mean doing the checks on upstream sources? Sure, what would have some value, but the more downstream patches the less trustworthy it would be.

@nforro nforro force-pushed the rebase_decision branch 2 times, most recently from c9d3933 to 9f3c60f Compare July 9, 2025 14:06
@nforro nforro marked this pull request as ready for review July 9, 2025 14:07
@nforro nforro force-pushed the rebase_decision branch from b6d8775 to 918c636 Compare July 9, 2025 14:08
Copy link
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, very nice writeup, let's merge

@nforro nforro added this pull request to the merge queue Jul 21, 2025
Merged via the queue into packit:main with commit a111273 Jul 21, 2025
2 checks passed
@nforro nforro deleted the rebase_decision branch July 21, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants