Skip to content

Fix EVR regex to not match email addresses with - in them #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
softwarefactory-project-zuul merged 1 commit into from
Jan 8, 2025
Merged

Fix EVR regex to not match email addresses with - in them #445

softwarefactory-project-zuul merged 1 commit into from
Jan 8, 2025

Conversation

@dcermak
Copy link
Contributor

@dcermak dcermak commented Jan 6, 2025 •
edited
Loading

TODO:

  • Write new tests or update the old ones to cover new functionality.
  • Update doc-strings where appropriate.
  • Update or write new documentation in packit/packit.dev.

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 6, 2025

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/c0bc407a7f8841c9b85106587ae14f12

✔️ pre-commit SUCCESS in 1m 49s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 01s
✔️ specfile-tests-pip-deps SUCCESS in 1m 00s

nforro
nforro reviewed Jan 7, 2025
View reviewed changes
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 7, 2025

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/403ac6aa2d114429adc21c995c4f49c6

✔️ pre-commit SUCCESS in 1m 49s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 04s
✔️ specfile-tests-pip-deps SUCCESS in 1m 00s

@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 7, 2025

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/006e8231e6624ec1af09d4479291f088

✔️ pre-commit SUCCESS in 1m 51s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 02s
✔️ specfile-tests-pip-deps SUCCESS in 58s

nforro
nforro reviewed Jan 8, 2025
View reviewed changes
nforro
nforro reviewed Jan 8, 2025
View reviewed changes
nforro
nforro reviewed Jan 8, 2025
View reviewed changes
@dcermak @nforro
Convert ChangelogEntry.evr to return an EVR
10a7f1e 
Also, adjust the EVR code to ensure that we don't match emails as EVRs

Co-authored-by: Nikola Forró <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 8, 2025

Build succeeded.
https://softwarefactory-project.io/zuul/t/packit-service/buildset/d506c4b56db94fe0b2d34bc97a1cc967

✔️ pre-commit SUCCESS in 1m 48s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 03s
✔️ specfile-tests-pip-deps SUCCESS in 1m 00s

nforro
nforro approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@nforro nforro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nforro
Copy link
Member

nforro commented Jan 8, 2025

/packit test

@nforro
Copy link
Member

nforro commented Jan 8, 2025

/packit-stg test

@nforro
Copy link
Member

nforro commented Jan 8, 2025

/packit-stg build

@nforro
Copy link
Member

nforro commented Jan 8, 2025

/packit build

@nforro nforro added the mergeit Merge via Zuul label Jan 8, 2025
@softwarefactory-project-zuul
Copy link
Contributor

softwarefactory-project-zuul bot commented Jan 8, 2025

Build succeeded (gate pipeline).
https://softwarefactory-project.io/zuul/t/packit-service/buildset/a57e39e83b6b48188e4fb6422b778e78

✔️ pre-commit SUCCESS in 1m 51s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 7876726 into packit:main Jan 8, 2025
32 of 34 checks passed
@mfocko mfocko mentioned this pull request Jan 10, 2025
Closed
@dcermak dcermak deleted the evr-regex branch January 14, 2025 09:34
@nforro nforro mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nforro nforro nforro approved these changes

Assignees

No one assigned

Labels

mergeit Merge via Zuul

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcermak @nforro