context_management: use ParamSpec from typing_extensions #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python < 3.10 does not have ParamSpec, so we need to import it from typing_extensions.
gotmax23
force-pushed
the
contextmanager-type-check-fix
branch
from
27f3af8 to
214f641
Compare
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 58s |
nforro
reviewed
Apr 2, 2025
Contributor
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 56s |
softwarefactory-project-zuul
bot
merged commit edc0f6d
into
packit:main
43 of 44 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python < 3.10 does not have ParamSpec, so we need to import it from typing_extensions.
Fixes #457
RELEASE NOTES BEGIN
The
context_managementtype stubs now useParamSpecfromtyping_extensionsto support Python < 3.10.RELEASE NOTES END