Fix escaping of options #476
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikola Forró <[email protected]>
Contributor
|
Build succeeded. ✔️ pre-commit SUCCESS in 1m 56s |
mfocko
approved these changes
May 20, 2025
Contributor
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 1m 57s |
softwarefactory-project-zuul
bot
merged commit c4c411d
into
main
40 of 41 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At first I thought it will be necessary to introduce a new token type and rewrite the code so that option values and positional arguments can consist of multiple tokens, but fortunately this simple fix works as well.
Fixes #475.
RELEASE NOTES BEGIN
We have fixed a bug that caused specfile to traceback when section names with conditional macro expansions containing spaces were present in the spec file.
RELEASE NOTES END