QoL changes #16
Merged
QoL changes #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Focko <[email protected]>
updates: - [github.com/pre-commit/pre-commit-hooks: v4.6.0 → v5.0.0](pre-commit/pre-commit-hooks@v4.6.0...v5.0.0) - [github.com/astral-sh/ruff-pre-commit: v0.5.0 → v0.7.2](astral-sh/ruff-pre-commit@v0.5.0...v0.7.2) - [github.com/pre-commit/mirrors-mypy: v1.10.1 → v1.13.0](pre-commit/mirrors-mypy@v1.10.1...v1.13.0) - [github.com/gitleaks/gitleaks: v8.18.4 → v8.21.2](gitleaks/gitleaks@v8.18.4...v8.21.2) - [github.com/python-jsonschema/check-jsonschema: 0.28.6 → 0.29.4](python-jsonschema/check-jsonschema@0.28.6...0.29.4) (cherry picked from commit d878cb6) Supersedes and closes packit#13
Signed-off-by: Matej Focko <[email protected]>
So we can type check missing implementations more easily. Signed-off-by: Matej Focko <[email protected]>
And also make it abstract property at the same time. Signed-off-by: Matej Focko <[email protected]>
We're logging the contents of those constants and suffixing it with “minutes”, yet... the constant »actually« holds seconds (given the usage of ‹timedelta›). Therefore drop the multiples of ‹60› and use ‹minutes› in the ‹timedelta› construction. Related to packit#15 Signed-off-by: Matej Focko <[email protected]>
After going through the Sentry I've noticed we have missed (or it got reformatted) some f-strings, so the constants for timeouts were not interpolated into the log messages. Signed-off-by: Matej Focko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details see individual commits.
TODO:
[validation], so it's easier to search for in Sentry?productionwhereasprodis the Service itself)