Skip to content

Update ubuntu xenial gcc version to 8.2.0 #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Update ubuntu xenial gcc version to 8.2.0 #110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ubuntu/xenial/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,12 @@ RUN apt-get update && apt-get install -y --force-yes \
alien \
dh-systemd

# Install gcc-8
RUN add-apt-repository ppa:ubuntu-toolchain-r/test -y && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is too Tarantool-specific. If you want to do these changes at this repository, you should update all Ubuntu images where GCC version < 8 for consistency. Otherwise, it looks very strange to update Ubuntu Xenial only.

I suggest creating own Docker image on the base of PackPack Ubuntu Xenial image and put it in the tarantool/testing repo on Docker Hub. In this case, you will be able to adjust the image as you need.

apt-get update -y && \
apt-get install gcc-8 g++-8 -y && \
update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-8 60 --slave /usr/bin/g++ g++ /usr/bin/g++-8 && \
update-alternatives --config gcc

# Enable sudo without password
RUN echo '%adm ALL=(ALL) NOPASSWD:ALL' >> /etc/sudoers