-
-
Notifications
You must be signed in to change notification settings - Fork 113
Feat/purego #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Feat/purego #455
Conversation
|
We could use pact-go bin to download the library, and act as a runner wrapper over go test, which sets the env var to the shared library, wherever the user has installed it. the install and run could be wrapped so if we can find the shared library, it asks the user to install it This will remove the need for sudo we would also create arch specific golang packages for each arch/plat if poss (would that need seperate repos) |
users now required to set PACT_LD_LIBRARY_PATH env var with location of download pact ffi lib. It can exist anywhere on the filesystem
to automatically set PACT_LD_LIBRARY_PATH
|
Okay, so this is pretty neato now.
the config file in
Users can still use No special paths are required, and we don't need to code them directly into our source code, they don't need to be well known paths, for library loading on macos, with sip enabled, so no sudo required 🎉 The only reservation is the purego project is still in beta, but with everything passing in our suites, I think I would still go for it, for the simplified developer experience. |
|
This takes the approach
with no fallback to the existing cgo mechanism to avoid code complexity |
fixes #452