fix(v3): pass cors option to mock server transport, defaulting to true - #1767
Merged
Conversation
Agent-Logs-Url: https://github.com/pact-foundation/pact-js/sessions/3b6b9f83-fd6c-46e7-a8ee-49d77d5fd9d0 Co-authored-by: mefellows <53900+mefellows@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pact-foundation/pact-js/sessions/3b6b9f83-fd6c-46e7-a8ee-49d77d5fd9d0 Co-authored-by: mefellows <53900+mefellows@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pact-foundation/pact-js/sessions/3b6b9f83-fd6c-46e7-a8ee-49d77d5fd9d0 Co-authored-by: mefellows <53900+mefellows@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix DELETE request handling in PactV3 mock server
fix(v3): pass cors option to mock server transport, defaulting to true
May 4, 2026
Agent-Logs-Url: https://github.com/pact-foundation/pact-js/sessions/0469f128-529e-4616-850f-89a788858eef Co-authored-by: mefellows <53900+mefellows@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pact-foundation/pact-js/sessions/887f9719-bf00-4906-a34b-58fa3138e197 Co-authored-by: mefellows <53900+mefellows@users.noreply.github.com>
Agent-Logs-Url: https://github.com/pact-foundation/pact-js/sessions/e718d4e2-4cec-4c16-91ad-ae35342acd7c Co-authored-by: mefellows <53900+mefellows@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds CORS pre-flight option to configuration and properly wires it through.
The previous mock server behaviour was to automatically enable CORS, and the user-specified configuration was ignored. Updated
PactV3interface, and adds support to thePactV4(Pact) interface.Fixes #1696